-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup todos #395
cleanup todos #395
Conversation
PTAL. |
@@ -102,7 +102,6 @@ RootSpan.prototype.getTraceContext = function() { | |||
/** | |||
* PluginAPI constructor. Don't call directly - a plugin object will be passed to | |||
* plugin themselves | |||
* TODO(kjin): Should be called something else |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
var span = setupSpan(api, cmd.command, cmd.args, 0); | ||
if (!span) { | ||
return internal_send_command.call(this, cmd, args, cb); | ||
return internal_send_command.call(this, cmd); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -34,17 +34,13 @@ var assert = require('assert'); | |||
var config = require('../config.js'); | |||
var file = require('../src/trace-agent.js'); | |||
var SpanData = require('../src/span-data.js'); | |||
// TODO: This line will silently fail if a logger is not supplied as | |||
// the second argument. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
No description provided.